extensions/common/features/simple_feature.cc - Issue 2141703003: [Extensions] Clean up renderer channel-related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/simple_feature.cc

Issue 2141703003: [Extensions] Clean up renderer channel-related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_feature_no_filter

Patch Set: Test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/chrome_extensions_client.cc ('K') | « extensions/common/features/feature_util.cc ('k') | extensions/common/features/simple_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/simple_feature.cc

diff --git a/extensions/common/features/simple_feature.cc b/extensions/common/features/simple_feature.cc

index b4a39198bcd62498e6f5c0ab5ee210556a1b7227..d2af884639d005293a9f3ee0105a86891a4754ea 100644

--- a/extensions/common/features/simple_feature.cc

+++ b/extensions/common/features/simple_feature.cc

@@ -427,7 +427,7 @@ Feature::Availability SimpleFeature::IsAvailableToManifest(

return CreateAvailability(MISSING_COMMAND_LINE_SWITCH, type);

}

- if (channel_ && check_channel_ && *channel_ < GetCurrentChannel())

+ if (channel_ && *channel_ < GetCurrentChannel())

return CreateAvailability(UNSUPPORTED_CHANNEL, *channel_);

return CheckDependencies(base::Bind(&IsAvailableToManifestForBind,