Make initializing formal access available by default

Make initializing formal access available by default

This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/4912fd150100210762a90b7dbbbc238b9ec5bb43

[eernst, 2016-07-12 12:53:32]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-07-12 12:53:33]

A CL which is intended to be ready for use later on: Enable
--initializing-formal-access by default.

[eernst, 2016-07-12 13:03:44]

Removed `enableInitializingFormalAccess` entirely from `CompilerOptions`.
It was confusing and unnecessary to have it around now that it is ignored
by the implementation.

[Johnni Winther, 2016-07-13 07:38:00]

lgtm

[eernst, 2016-07-25 16:05:14]

Finally got around to run all tests. This CL contains fixes coming up from that.

[eernst, 2016-07-26 07:28:27]

On 2016/07/25 16:05:14, eernst wrote:
> Finally got around to run all tests. This CL contains fixes coming up from
that.

Unfortunately, there is some noise in this CL due to a rebase unto
the current master. The relevant changes are in the "2" patch of
parameter_initializer5*.dart and in the status files.

[Johnni Winther, 2016-07-26 08:18:12]

lgtm

[eernst, 2016-07-27 08:54:43]

This CL adjusts one more test that fails when init. formal access is on by
default (the test needs a compile time error, it used initializing formal access
to get that, but it is not an error any more -- now the test uses access to
`this` in an initializer to get the error).

PS: Someone made me build a fresh `dart` yesterday, and then I made the mistake
of not going back to the dev. branch when running the last batch of test cases,
so I missed one failure. ;)

[Johnni Winther, 2016-08-01 09:01:04]

Still LGTM

[eernst, 2016-11-24 17:44:51]

PTAL: It took a number of edits to port this CL to the current master (so "ALL
4" includes all kinds of not-from-this-CL diff chunks), but there should not be
anything controversial in here.

[eernst, 2016-11-24 17:55:03]

One thing to note: We discussed how to handle the `DartOptions` directives.
Florian preferred that we keep them in the test files for now, and ask the
analyzer team to remove them when they are ready (dart2js works both with and
without them, but the analyzer only works with them). So I created an issue for
that (https://github.com/dart-lang/sdk/issues/27895).

[Johnni Winther, 2016-11-25 08:23:29]

lgtm

[eernst, 2016-11-25 09:15:42]

Description was changed from

==========
Make initializing formal access available by default

This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.
==========

to

==========
Make initializing formal access available by default

This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4912fd150100210762a90b7dbbbc238b9ec5bb43
==========

[eernst, 2016-11-25 09:15:43]

Committed patchset #5 (id:80001) manually as
4912fd150100210762a90b7dbbbc238b9ec5bb43 (presubmit successful).