pkg/compiler/lib/src/resolution/members.dart - Issue 2141023002: Make initializing formal access available by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2141023002: Make initializing formal access available by default (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Additional clean-up, now ready to land Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index 27f164f94d1af5502eacaa862035eda40d8ce5bd..f566e405dcc5eb6b5fa34bfa8aa3739bfb8f5867 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -2573,8 +2573,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

} else {

semantics = new StaticAccess.parameter(element);

}

- } else if (element.isInitializingFormal &&

- options.enableInitializingFormalAccess) {

+ } else if (element.isInitializingFormal) {

error = reportAndCreateErroneousElement(node.selector, name.text,

MessageKind.UNDEFINED_STATIC_SETTER_BUT_GETTER, {'name': name});

semantics = new StaticAccess.finalParameter(element);