Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/compiler/lib/src/options.dart

Issue 2141023002: Make initializing formal access available by default (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Additional clean-up, now ready to land Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/resolution/constructors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/options.dart
diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
index 2d33ec0547b6e03cc3f6c93a7edf44149b994fdf..70594dc2ae3e120a58895129982f6c8d856a7929 100644
--- a/pkg/compiler/lib/src/options.dart
+++ b/pkg/compiler/lib/src/options.dart
@@ -133,10 +133,6 @@ class CompilerOptions implements DiagnosticOptions {
/// reason for why an assertion fails. (experimental)
final bool enableAssertMessage;
- /// Support access to initializing formal constructor arguments, e.g., the
- /// use of `x` to initialize `y` in `C(this.x) : y = x`.
- final bool enableInitializingFormalAccess;
-
/// Whether the user specified a flag to allow the use of dart:mirrors. This
/// silences a warning produced by the compiler.
final bool enableExperimentalMirrors;
@@ -272,8 +268,6 @@ class CompilerOptions implements DiagnosticOptions {
disableTypeInference: _hasOption(options, Flags.disableTypeInference),
dumpInfo: _hasOption(options, Flags.dumpInfo),
enableAssertMessage: _hasOption(options, Flags.enableAssertMessage),
- enableInitializingFormalAccess:
- _hasOption(options, Flags.initializingFormalAccess),
enableExperimentalMirrors:
_hasOption(options, Flags.enableExperimentalMirrors),
enableMinification: _hasOption(options, Flags.minify),
@@ -340,7 +334,6 @@ class CompilerOptions implements DiagnosticOptions {
bool disableTypeInference: false,
bool dumpInfo: false,
bool enableAssertMessage: false,
- bool enableInitializingFormalAccess: false,
bool enableExperimentalMirrors: false,
bool enableMinification: false,
bool enableNativeLiveTypeAnalysis: true,
@@ -411,7 +404,6 @@ class CompilerOptions implements DiagnosticOptions {
disableTypeInference: disableTypeInference,
dumpInfo: dumpInfo,
enableAssertMessage: enableAssertMessage,
- enableInitializingFormalAccess: enableInitializingFormalAccess,
enableExperimentalMirrors: enableExperimentalMirrors,
enableMinification: enableMinification,
enableNativeLiveTypeAnalysis: enableNativeLiveTypeAnalysis,
@@ -461,7 +453,6 @@ class CompilerOptions implements DiagnosticOptions {
this.disableTypeInference: false,
this.dumpInfo: false,
this.enableAssertMessage: false,
- this.enableInitializingFormalAccess: false,
this.enableExperimentalMirrors: false,
this.enableMinification: false,
this.enableNativeLiveTypeAnalysis: false,
@@ -518,7 +509,6 @@ class CompilerOptions implements DiagnosticOptions {
disableTypeInference,
dumpInfo,
enableAssertMessage,
- enableInitializingFormalAccess,
enableExperimentalMirrors,
enableMinification,
enableNativeLiveTypeAnalysis,
@@ -576,8 +566,6 @@ class CompilerOptions implements DiagnosticOptions {
disableTypeInference ?? options.disableTypeInference,
dumpInfo: dumpInfo ?? options.dumpInfo,
enableAssertMessage: enableAssertMessage ?? options.enableAssertMessage,
- enableInitializingFormalAccess: enableInitializingFormalAccess ??
- options.enableInitializingFormalAccess,
enableExperimentalMirrors:
enableExperimentalMirrors ?? options.enableExperimentalMirrors,
enableMinification: enableMinification ?? options.enableMinification,
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/resolution/constructors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698