appengine/cmd/milo/swarming/build.go - Issue 2141013003: milo: fix build/step timing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/swarming/build.go

Issue 2141013003: milo: fix build/step timing (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: retrain Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/milo/swarming/build.go

diff --git a/appengine/cmd/milo/swarming/build.go b/appengine/cmd/milo/swarming/build.go

index 01d2fa51cf37c10c5f8062aa5f662d2834de63d5..1ad929a5a59b1e8e69801a1e5b5fbdf6c51521c7 100644

--- a/appengine/cmd/milo/swarming/build.go

+++ b/appengine/cmd/milo/swarming/build.go

@@ -253,7 +253,7 @@ func taskToBuild(c context.Context, server string, sr *swarming.SwarmingRpcsTask

}

if sr.CompletedTs != "" {

- build.Summary.Finished, err = time.Parse(SwarmingTimeLayout, sr.StartedTs)

+ build.Summary.Finished, err = time.Parse(SwarmingTimeLayout, sr.CompletedTs)

if err != nil {

return nil, fmt.Errorf("invalid task CompletedTs: %s", err)

}

« no previous file with comments | « appengine/cmd/milo/settings/funcs_test.go ('k') | appengine/cmd/milo/swarming/build_test.go » ('j') | no next file with comments »