appengine/cmd/milo/resp/build.go - Issue 2141013003: milo: fix build/step timing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/resp/build.go

Issue 2141013003: milo: fix build/step timing (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: retrain Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/milo/resp/build.go

diff --git a/appengine/cmd/milo/resp/build.go b/appengine/cmd/milo/resp/build.go

index 8eac13ae5557362e3441a10f492149523aefd632..75e4c7f464a274f27d6ed5042bcdced8b09a087f 100644

--- a/appengine/cmd/milo/resp/build.go

+++ b/appengine/cmd/milo/resp/build.go

@@ -139,6 +139,16 @@ const (

WaitingDependency // 100 Brown

)

+// Terminal returns true if the step status won't change.

+func (s Status) Terminal() bool {

+ switch s {

+ case Success, Failure, InfraFailure, Warning, DependencyFailure:

+ return true

+ default:

+ return false

+ }

// MarshalJSON renders enums into String rather than an int when marshalling.

func (s Status) MarshalJSON() ([]byte, error) {

return json.Marshal(s.String())

« no previous file with comments | « appengine/cmd/milo/logdog/logDogBuild.go ('k') | appengine/cmd/milo/settings/funcs_test.go » ('j') | no next file with comments »