Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2138843003: Add support for setting sheriff-specific bug labels. (Closed)

Created:
4 years, 5 months ago by sullivan
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add support for setting sheriff-specific bug labels. This makes it possible to only apply the 'Performance-Sheriff' label to the main rotation's bugs, as well as allow other rotations their own labels. BUG=catapult:#2463 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cc2f04068f9747880001ebf797cc2a33abab3179

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M dashboard/dashboard/edit_sheriffs.py View 2 chunks +6 lines, -0 lines 0 comments Download
M dashboard/dashboard/edit_sheriffs_test.py View 1 6 chunks +9 lines, -3 lines 0 comments Download
M dashboard/dashboard/email_sheriff_test.py View 1 chunk +3 lines, -1 line 0 comments Download
M dashboard/dashboard/email_summary_test.py View 1 4 chunks +4 lines, -3 lines 0 comments Download
M dashboard/dashboard/email_template.py View 2 chunks +3 lines, -2 lines 0 comments Download
M dashboard/dashboard/file_bug.py View 2 chunks +3 lines, -1 line 0 comments Download
M dashboard/dashboard/file_bug_test.py View 2 chunks +3 lines, -1 line 0 comments Download
M dashboard/dashboard/models/sheriff.py View 1 chunk +3 lines, -0 lines 0 comments Download
M dashboard/dashboard/send_stoppage_alert_emails.py View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/templates/edit_sheriffs.html View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
sullivan
The deploy plan for this would be: 1) Deploy as non-default, update 'Chromium Perf Sheriff' ...
4 years, 5 months ago (2016-07-11 21:00:15 UTC) #9
sullivan
Kari, can you take a look?
4 years, 4 months ago (2016-08-01 14:01:50 UTC) #17
aiolos (Not reviewing)
lgtm, but we should have the current sheriff help test the non-default version before we ...
4 years, 4 months ago (2016-08-01 16:16:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138843003/20001
4 years, 4 months ago (2016-08-01 16:47:28 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 17:14:48 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698