Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2887)

Unified Diff: dashboard/dashboard/edit_sheriffs.py

Issue 2138843003: Add support for setting sheriff-specific bug labels. (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Fix unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/edit_sheriffs_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/edit_sheriffs.py
diff --git a/dashboard/dashboard/edit_sheriffs.py b/dashboard/dashboard/edit_sheriffs.py
index cb161219cedf5352f2a7fcbf70c09160dcb358cc..3654ffe240479d853438b0d595e8eeab97de7022 100644
--- a/dashboard/dashboard/edit_sheriffs.py
+++ b/dashboard/dashboard/edit_sheriffs.py
@@ -33,6 +33,7 @@ class EditSheriffsHandler(edit_config_handler.EditConfigHandler):
'url': sheriff_entity.url or '',
'email': sheriff_entity.email or '',
'patterns': '\n'.join(sorted(sheriff_entity.patterns)),
+ 'labels': ','.join(sorted(sheriff_entity.labels)),
'internal_only': sheriff_entity.internal_only,
'summarize': sheriff_entity.summarize,
'stoppage_alert_delay': sheriff_entity.stoppage_alert_delay or 0,
@@ -56,6 +57,11 @@ class EditSheriffsHandler(edit_config_handler.EditConfigHandler):
sheriff_entity.url = self.request.get('url') or None
sheriff_entity.email = self.request.get('email') or None
sheriff_entity.internal_only = self.request.get('internal-only') == 'true'
+ labels = self.request.get('labels')
+ if labels:
+ sheriff_entity.labels = labels.split(',')
+ else:
+ sheriff_entity.labels = []
sheriff_entity.summarize = self.request.get('summarize') == 'true'
stoppage_alert_delay = self.request.get('stoppage-alert-delay')
if stoppage_alert_delay and int(stoppage_alert_delay) > 0:
« no previous file with comments | « no previous file | dashboard/dashboard/edit_sheriffs_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698