Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: dashboard/dashboard/email_summary_test.py

Issue 2138843003: Add support for setting sheriff-specific bug labels. (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Fix unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/email_sheriff_test.py ('k') | dashboard/dashboard/email_template.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/email_summary_test.py
diff --git a/dashboard/dashboard/email_summary_test.py b/dashboard/dashboard/email_summary_test.py
index 7b0137537d0b9b45928e5bda69fb64cc050991d3..238e6b3e871a360d691e86c45327ece720b878d3 100644
--- a/dashboard/dashboard/email_summary_test.py
+++ b/dashboard/dashboard/email_summary_test.py
@@ -48,7 +48,7 @@ class EmailSummaryTest(testing_common.TestCase):
"""Adds a sheriff with summarize set to False, and some alerts."""
sheriff_key = sheriff.Sheriff(
id='Chromium Perf Sheriff', email='anandc@google.com',
- summarize=False).put()
+ summarize=False, labels=['Performance-Sheriff']).put()
testing_common.AddTests(['ChromiumGPU'], ['linux-release'], {
'scrolling-benchmark': {
'first_paint': {},
@@ -63,7 +63,7 @@ class EmailSummaryTest(testing_common.TestCase):
def _AddFourNewAlertsWithSummaryForOnlyTwo(self):
sheriff_key = sheriff.Sheriff(
id='Chromium Perf Sheriff', email='anandc@google.com',
- summarize=True).put()
+ summarize=True, labels=['Performance-Sheriff']).put()
testing_common.AddTests(['ChromiumGPU'], ['linux-release'], {
'scrolling-benchmark': {
'first_paint': {},
@@ -92,6 +92,7 @@ class EmailSummaryTest(testing_common.TestCase):
"""Adds alerts for two separate sheriffs which both have summarize=True."""
sheriff_key = sheriff.Sheriff(
id='Chromium Perf Sheriff', email='anandc@google.com',
+ labels=['Performance-Sheriff'],
summarize=True).put()
testing_common.AddTests(['ChromiumGPU'], ['linux-release'], {
'scrolling-benchmark': {
@@ -134,7 +135,7 @@ class EmailSummaryTest(testing_common.TestCase):
self.assertIn('A <b>100.0%</b> regression', html)
self.assertNotIn('A <b>50.0%</b> regression', html)
self.assertIn(
- 'labels=Type-Bug-Regression,Pri-2,Performance-Sheriff,\'', html)
+ 'labels=Type-Bug-Regression,Pri-2,Performance-Sheriff\'', html)
self.assertIn(
'labels=Type-Bug-Regression,Pri-2,Performance-Sheriff,label1\'', html)
« no previous file with comments | « dashboard/dashboard/email_sheriff_test.py ('k') | dashboard/dashboard/email_template.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698