dashboard/dashboard/email_template.py - Issue 2138843003: Add support for setting sheriff-specific bug labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/email_template.py

Issue 2138843003: Add support for setting sheriff-specific bug labels. (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Fix unit tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/email_template.py

diff --git a/dashboard/dashboard/email_template.py b/dashboard/dashboard/email_template.py

index 937bc6c539357f6d454b1de402dc2139c30c4587..c353f45bc135bcb027f1157dc622e9bac1b8cf07 100644

--- a/dashboard/dashboard/email_template.py

+++ b/dashboard/dashboard/email_template.py

@@ -50,7 +50,7 @@ _BUG_REPORT_COMMENT = (

_BUG_REPORT_LINK_URL = (

'https://code.google.com/p/chromium/issues/entry?summary=%s&comment=%s&'

- 'labels=Type-Bug-Regression,Pri-2,Performance-Sheriff,%s')

+ 'labels=Type-Bug-Regression,Pri-2,%s')

_ALL_ALERTS_LINK = (

'<a href="https://chromeperf.appspot.com/alerts?sheriff=%s">'

@@ -299,7 +299,8 @@ def GetAlertInfo(alert, test):

bug_comment = _BUG_REPORT_COMMENT % interpolation_parameters

bug_summary = ('%(percent_changed)s %(change_type)s in %(test_name)s '

'on %(bot)s at %(start)d:%(end)d') % interpolation_parameters

- labels = bug_label_patterns.GetBugLabelsForTest(test)

+ labels = (alert.sheriff.get().labels +

+ bug_label_patterns.GetBugLabelsForTest(test))

bug_url = _BUG_REPORT_LINK_URL % (

urllib.quote(bug_summary), urllib.quote(bug_comment), ','.join(labels))

« no previous file with comments | « dashboard/dashboard/email_summary_test.py ('k') | dashboard/dashboard/file_bug.py » ('j') | no next file with comments »