Perform BSP polygon splitting and orientation selection in a single step.

Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)

[Tobias Sargeant, 2016-07-08 11:00:45]

Description was changed from

==========
Sheriffing: disable three failing tests

The following layout test is failing on Win7 debug:

compositing/perpendicular-layer-sorting.html
transforms/3d/point-mapping/3d-point-mapping-deep.html
transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html

3d-point-mapping-preserve-3d.html is also failing on Mac and Linux.

These are failing since r403584, which is auto-rebaseline for tobiasjs' r403559.

BUG=606302
TBR=tobiasjs@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2120893002
Cr-Commit-Position: refs/heads/master@{#403635}
(cherry picked from commit 97f34fffe2696482fb16ea7945e4aab2ff28a179)

Auto-rebaseline for r403559

https://chromium.googlesource.com/chromium/src/+/3e9082bfc

BUG=606984
TBR=tobiasjs@chromium.org

Review URL: https://codereview.chromium.org/2120543004 .

Cr-Commit-Position: refs/heads/master@{#403584}
(cherry picked from commit e89b7f8b8ee5ef77e80a96ff2be3012c156a51d6)

Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

to

==========
Sheriffing: disable three failing tests

The following layout test is failing on Win7 debug:

compositing/perpendicular-layer-sorting.html
transforms/3d/point-mapping/3d-point-mapping-deep.html
transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html

3d-point-mapping-preserve-3d.html is also failing on Mac and Linux.

These are failing since r403584, which is auto-rebaseline for tobiasjs' r403559.

BUG=606302
TBR=tobiasjs@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2120893002
Cr-Commit-Position: refs/heads/master@{#403635}
(cherry picked from commit 97f34fffe2696482fb16ea7945e4aab2ff28a179)

Auto-rebaseline for r403559

https://chromium.googlesource.com/chromium/src/+/3e9082bfc

BUG=606984
TBR=tobiasjs@chromium.org

Review URL: https://codereview.chromium.org/2120543004 .

Cr-Commit-Position: refs/heads/master@{#403584}
(cherry picked from commit e89b7f8b8ee5ef77e80a96ff2be3012c156a51d6)

Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

[Tobias Sargeant, 2016-07-08 11:06:56]

tobiasjs@chromium.org changed reviewers:
+ amineer@chromium.org, danakj@chromium.org

[Tobias Sargeant, 2016-07-08 11:06:56]

Hi Dana and Alex,

Could you please take a look at this cherry-pick as a sanity check? I discussed
with Alex, and said I would try to find out what the best plan was, but haven't
been able to get a concrete answer, so this is my best guess.

Situation is:

Original patch (BSP polygon splitting) is approved for merge to m52 to fix a
use-after-free. But it comes with a change to layout test TextExpectations that
conflicts (TestExpectation has diverged a lot since m52 branch, unsurprisingly).
It was also followed on trunk by a rebaseline, and then re-disabling of tests
that are still not fixed.

I've merged the 3 CLs into one for the cherry-pick, because I presume that
landing with rebaselines on a branch won't do anything, and Alex says that tests
still run on the branch so I don't want to just skip the test changes.

[danakj, 2016-07-08 21:24:36]

danakj@chromium.org changed reviewers:
+ enne@chromium.org
- danakj@chromium.org

[danakj, 2016-07-08 21:24:37]

=> the original reviewer

[enne (OOO), 2016-07-08 21:28:10]

I don't know that it's worth moving new baselines to branches.  There's not
really infrastructure support for them and I don't think that they are run. 
It'd be better to just mark all the tests as failing and call it a day.  I don't
think there's going to be any regressions here that would not be seen elsewhere.

[amineer, 2016-07-08 21:43:27]

On 2016/07/08 21:28:10, enne wrote:
> I don't know that it's worth moving new baselines to branches.  There's not
> really infrastructure support for them and I don't think that they are run. 
> It'd be better to just mark all the tests as failing and call it a day.  I
don't
> think there's going to be any regressions here that would not be seen
elsewhere.

Ah, here are the tests that are run on branches:
https://uberchromegw.corp.google.com/i/official.android.continuous/builders/t...

So you are right, it looks like they don't run LayoutTests - sorry Toby, I got
these mixed up with the tests that did run :\

[Tobias Sargeant, 2016-07-11 09:52:06]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 09:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 09:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:52:19]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Tobias Sargeant, 2016-07-11 09:52:39]

Description was changed from

==========
Sheriffing: disable three failing tests

The following layout test is failing on Win7 debug:

compositing/perpendicular-layer-sorting.html
transforms/3d/point-mapping/3d-point-mapping-deep.html
transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html

3d-point-mapping-preserve-3d.html is also failing on Mac and Linux.

These are failing since r403584, which is auto-rebaseline for tobiasjs' r403559.

BUG=606302
TBR=tobiasjs@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2120893002
Cr-Commit-Position: refs/heads/master@{#403635}
(cherry picked from commit 97f34fffe2696482fb16ea7945e4aab2ff28a179)

Auto-rebaseline for r403559

https://chromium.googlesource.com/chromium/src/+/3e9082bfc

BUG=606984
TBR=tobiasjs@chromium.org

Review URL: https://codereview.chromium.org/2120543004 .

Cr-Commit-Position: refs/heads/master@{#403584}
(cherry picked from commit e89b7f8b8ee5ef77e80a96ff2be3012c156a51d6)

Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

to

==========
Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

[Tobias Sargeant, 2016-07-11 10:37:44]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2016-07-11 10:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 10:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 10:38:01]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[enne (OOO), 2016-07-11 17:35:52]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-07-11 17:35:52]

lgtm

[commit-bot: I haz the power, 2016-07-11 17:36:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 17:36:27]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[enne (OOO), 2016-07-11 17:44:02]

Description was changed from

==========
Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

to

==========
Perform BSP polygon splitting and orientation selection in a single step.

This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.

Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.

BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
Review-Url: https://codereview.chromium.org/2043283002
Cr-Original-Commit-Position: refs/heads/master@{#399459}
Cr-Commit-Position: refs/heads/master@{#403559}
(cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae)
==========

[enne (OOO), 2016-07-11 17:44:07]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-07-11 17:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:48:14]

Committed patchset #2 (id:20001)