Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith(). (Closed)

Created:
4 years, 5 months ago by markusheintz_
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, lazyboy
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, tracing+reviews_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, samuong+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, sync-reviews_chromium.org, wfh+watch_chromium.org, Aaron Boodman, davemoore+watch_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of place string::find(prefix) == 0 pattern with base::StartsWith(). (patchset #1 id:1 of https://codereview.chromium.org/2131933002/ ) Reason for revert: Reverting this revert since https://codereview.chromium.org/2135653002/ seems to fix the issue Original issue's description: > Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (patchset #2 id:20001 of https://codereview.chromium.org/2121513002/ ) > > Reason for revert: > Bisect believes that this CL caused the Win builder to break. > > https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267 > https://build.chromium.org/p/chromium/builders/Win/builds/45048 > > For context see: > https://bugs.chromium.org/p/chromium/issues/detail?id=626539 > > Original issue's description: > > Replace string::find(prefix) == 0 pattern with base::StartsWith(). > > > > base::StartsWith() should be O(|prefix|) whereas string::find() is > > pretty bad, O(|string| * |prefix|). > > > > TBR=jam@chromium.org > > BUG=None > > Test=None, internal cleanup. > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng > > > > Committed: https://crrev.com/53bfbe932191085b5d69f824a9923bccc26d58dc > > Cr-Commit-Position: refs/heads/master@{#404307} > > TBR=thestig@chromium.org,lazyboy@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Committed: https://crrev.com/f635836294b0221de8531e3ab3720d7fc18e65cd > Cr-Commit-Position: refs/heads/master@{#404341} TBR=thestig@chromium.org,lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/74e10b22e14d23d306351e94e3db01ca8f04ee8c Cr-Commit-Position: refs/heads/master@{#404342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
M base/trace_event/trace_config.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M components/leveldb/env_mojo.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/os_crypt/os_crypt_posix.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/sync_sessions/favicon_cache_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/dom_storage/session_storage_database.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/dom_storage/session_storage_database_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M content/browser/iframe_zoom_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/blink/buffered_resource_loader.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M net/base/filename_util.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/cookies/canonical_cookie.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/test_utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M sandbox/win/src/win_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
markusheintz_
Created Reland of place string::find(prefix) == 0 pattern with base::StartsWith().
4 years, 5 months ago (2016-07-08 13:17:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136453004/1
4 years, 5 months ago (2016-07-08 13:18:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 13:20:00 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 13:20:21 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 13:21:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74e10b22e14d23d306351e94e3db01ca8f04ee8c
Cr-Commit-Position: refs/heads/master@{#404342}

Powered by Google App Engine
This is Rietveld 408576698