net/cookies/canonical_cookie.cc - Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.cc

Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/canonical_cookie.cc

diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc

index 407c9ff20a450f0304af3297b2c1aff0c21f47c7..2469f28660aa073efe634e028a8c4c0a16d810eb 100644

--- a/net/cookies/canonical_cookie.cc

+++ b/net/cookies/canonical_cookie.cc

@@ -480,9 +480,9 @@

const std::string& name) {

const char kSecurePrefix[] = "__Secure-";

const char kHostPrefix[] = "__Host-";

- if (name.find(kSecurePrefix) == 0)

+ if (base::StartsWith(name, kSecurePrefix, base::CompareCase::SENSITIVE))

return CanonicalCookie::COOKIE_PREFIX_SECURE;

- if (name.find(kHostPrefix) == 0)

+ if (base::StartsWith(name, kHostPrefix, base::CompareCase::SENSITIVE))

return CanonicalCookie::COOKIE_PREFIX_HOST;

return CanonicalCookie::COOKIE_PREFIX_NONE;

}

« no previous file with comments | « net/base/filename_util.cc ('k') | ppapi/shared_impl/test_utils.cc » ('j') | no next file with comments »