content/browser/iframe_zoom_browsertest.cc - Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/iframe_zoom_browsertest.cc

Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/dom_storage/session_storage_database_unittest.cc ('k') | content/browser/webui/shared_resources_data_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/iframe_zoom_browsertest.cc

diff --git a/content/browser/iframe_zoom_browsertest.cc b/content/browser/iframe_zoom_browsertest.cc

index b74135ca51bf11d8aa6bc1ee09f223bbf479e3d1..80ba2665553ef0d77b153790a348242293dee050 100644

--- a/content/browser/iframe_zoom_browsertest.cc

+++ b/content/browser/iframe_zoom_browsertest.cc

@@ -4,6 +4,7 @@

#include <vector>

+#include "base/strings/string_util.h"

#include "content/browser/frame_host/frame_tree_node.h"

#include "content/browser/frame_host/render_frame_host_impl.h"

#include "content/browser/web_contents/web_contents_impl.h"

@@ -121,7 +122,7 @@

}

void Check(const std::string& status_msg) {

- if (status_msg.find(msg_label) != 0)

+ if (!base::StartsWith(status_msg, msg_label, base::CompareCase::SENSITIVE))

return;

double inner_width = std::stod(status_msg.substr(msg_label.length() + 1));