chrome/browser/profiles/profile_avatar_icon_util.cc - Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_avatar_icon_util.cc

Issue 2136453004: Reland of place string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_avatar_icon_util.cc

diff --git a/chrome/browser/profiles/profile_avatar_icon_util.cc b/chrome/browser/profiles/profile_avatar_icon_util.cc

index b0fa75e100f8c9fc9b0f30751efa80c68f36d899..7c197972c04aaf9f065123b6e6c5447256fe9a9f 100644

--- a/chrome/browser/profiles/profile_avatar_icon_util.cc

+++ b/chrome/browser/profiles/profile_avatar_icon_util.cc

@@ -13,6 +13,7 @@

#include "base/path_service.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_split.h"

+#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

@@ -487,7 +488,7 @@

bool IsDefaultAvatarIconUrl(const std::string& url, size_t* icon_index) {

DCHECK(icon_index);

- if (url.find(kDefaultUrlPrefix) != 0)

+ if (!base::StartsWith(url, kDefaultUrlPrefix, base::CompareCase::SENSITIVE))

return false;

int int_value = -1;

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | no next file with comments »