Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2136133002: Fix under-invalidation of frame scrollbar on hover (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ObjectInvalidation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix under-invalidation of frame scrollbar on hover Ensure the layoutView() of the frame is setMayNeedPaintInvalidation() when the scrollbar needs paint invalidation. BTW, combine PaintInvalidationCapableScrollableArea:: boxForScrollControlPaintInvalidation() and ScrollbarArea::layoutBox() which was added recently. BUG=625757 TEST=paint/invalidation/iframe-scrollbar-hover.html Committed: https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e Cr-Commit-Position: refs/heads/master@{#404958}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 19 (7 generated)
Xianzhu
4 years, 5 months ago (2016-07-11 18:33:42 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-11 19:03:00 UTC) #3
chrishtr
https://codereview.chromium.org/2136133002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html File third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html (right): https://codereview.chromium.org/2136133002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html#newcode5 third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html:5: eventSender.mouseMoveTo(195, 120); Is this going to be reliable on ...
4 years, 5 months ago (2016-07-11 19:03:26 UTC) #4
Xianzhu
Still need to wait for https://codereview.chromium.org/2137013003/ before landing. https://codereview.chromium.org/2136133002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html File third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html (right): https://codereview.chromium.org/2136133002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html#newcode5 third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html:5: eventSender.mouseMoveTo(195, ...
4 years, 5 months ago (2016-07-11 19:09:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136133002/1
4 years, 5 months ago (2016-07-11 22:59:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260376)
4 years, 5 months ago (2016-07-12 02:19:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136133002/1
4 years, 5 months ago (2016-07-12 18:09:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242818)
4 years, 5 months ago (2016-07-12 19:36:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136133002/1
4 years, 5 months ago (2016-07-12 22:06:58 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:26:28 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:26:30 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:28:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e
Cr-Commit-Position: refs/heads/master@{#404958}

Powered by Google App Engine
This is Rietveld 408576698