third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h - Issue 2136133002: Fix under-invalidation of frame scrollbar on hover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

Issue 2136133002: Fix under-invalidation of frame scrollbar on hover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ObjectInvalidation

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html ('K') | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

index d58342ef64769858f0db7f6ea8f91aff6fe705b5..4ef4a25c3896c7279cb173291b257738f1f79a34 100644

--- a/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h

@@ -37,10 +37,11 @@ public:

LayoutRect visualRectForScrollbarParts() const override;

private:

- virtual LayoutBox& boxForScrollControlPaintInvalidation() const = 0;

virtual LayoutScrollbarPart* scrollCorner() const = 0;

virtual LayoutScrollbarPart* resizer() const = 0;

+ void scrollControlWasSetNeedsPaintInvalidation() override;

bool m_horizontalScrollbarPreviouslyWasOverlay;

bool m_verticalScrollbarPreviouslyWasOverlay;

LayoutRect m_horizontalScrollbarPreviousPaintInvalidationRect;