Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2136133002: Fix under-invalidation of frame scrollbar on hover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ObjectInvalidation
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 } 212 }
213 213
214 GraphicsLayer* PaintLayerScrollableArea::layerForScrollCorner() const 214 GraphicsLayer* PaintLayerScrollableArea::layerForScrollCorner() const
215 { 215 {
216 // See crbug.com/343132. 216 // See crbug.com/343132.
217 DisableCompositingQueryAsserts disabler; 217 DisableCompositingQueryAsserts disabler;
218 218
219 return layer()->hasCompositedLayerMapping() ? layer()->compositedLayerMappin g()->layerForScrollCorner() : 0; 219 return layer()->hasCompositedLayerMapping() ? layer()->compositedLayerMappin g()->layerForScrollCorner() : 0;
220 } 220 }
221 221
222 void PaintLayerScrollableArea::scrollControlWasSetNeedsPaintInvalidation()
223 {
224 box().setMayNeedPaintInvalidation();
225 }
226
227 bool PaintLayerScrollableArea::shouldUseIntegerScrollOffset() const 222 bool PaintLayerScrollableArea::shouldUseIntegerScrollOffset() const
228 { 223 {
229 Frame* frame = box().frame(); 224 Frame* frame = box().frame();
230 if (frame->settings() && !frame->settings()->preferCompositingToLCDTextEnabl ed()) 225 if (frame->settings() && !frame->settings()->preferCompositingToLCDTextEnabl ed())
231 return true; 226 return true;
232 227
233 return ScrollableArea::shouldUseIntegerScrollOffset(); 228 return ScrollableArea::shouldUseIntegerScrollOffset();
234 } 229 }
235 230
236 bool PaintLayerScrollableArea::isActive() const 231 bool PaintLayerScrollableArea::isActive() const
(...skipping 1516 matching lines...) Expand 10 before | Expand all | Expand 10 after
1753 1748
1754 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as() 1749 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as()
1755 { 1750 {
1756 for (auto& scrollableArea : *s_needsClamp) 1751 for (auto& scrollableArea : *s_needsClamp)
1757 scrollableArea->clampScrollPositionsAfterLayout(); 1752 scrollableArea->clampScrollPositionsAfterLayout();
1758 delete s_needsClamp; 1753 delete s_needsClamp;
1759 s_needsClamp = nullptr; 1754 s_needsClamp = nullptr;
1760 } 1755 }
1761 1756
1762 } // namespace blink 1757 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698