Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2136133002: Fix under-invalidation of frame scrollbar on hover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ObjectInvalidation
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 251
252 // GraphicsLayers for the scrolling components. 252 // GraphicsLayers for the scrolling components.
253 // 253 //
254 // Any function can return nullptr if they are not accelerated. 254 // Any function can return nullptr if they are not accelerated.
255 GraphicsLayer* layerForHorizontalScrollbar() const override; 255 GraphicsLayer* layerForHorizontalScrollbar() const override;
256 GraphicsLayer* layerForVerticalScrollbar() const override; 256 GraphicsLayer* layerForVerticalScrollbar() const override;
257 GraphicsLayer* layerForScrollCorner() const override; 257 GraphicsLayer* layerForScrollCorner() const override;
258 258
259 bool usesCompositedScrolling() const override; 259 bool usesCompositedScrolling() const override;
260 bool shouldScrollOnMainThread() const override; 260 bool shouldScrollOnMainThread() const override;
261 void scrollControlWasSetNeedsPaintInvalidation() override;
262 bool shouldUseIntegerScrollOffset() const override; 261 bool shouldUseIntegerScrollOffset() const override;
263 bool isActive() const override; 262 bool isActive() const override;
264 bool isScrollCornerVisible() const override; 263 bool isScrollCornerVisible() const override;
265 IntRect scrollCornerRect() const override; 264 IntRect scrollCornerRect() const override;
266 IntRect convertFromScrollbarToContainingWidget(const Scrollbar&, const IntRe ct&) const override; 265 IntRect convertFromScrollbarToContainingWidget(const Scrollbar&, const IntRe ct&) const override;
267 IntRect convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntRe ct&) const override; 266 IntRect convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntRe ct&) const override;
268 IntPoint convertFromScrollbarToContainingWidget(const Scrollbar&, const IntP oint&) const override; 267 IntPoint convertFromScrollbarToContainingWidget(const Scrollbar&, const IntP oint&) const override;
269 IntPoint convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntP oint&) const override; 268 IntPoint convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntP oint&) const override;
270 int scrollSize(ScrollbarOrientation) const override; 269 int scrollSize(ScrollbarOrientation) const override;
271 IntPoint scrollPosition() const override; 270 IntPoint scrollPosition() const override;
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 return m_rareData.get(); 481 return m_rareData.get();
483 } 482 }
484 483
485 PaintLayerScrollableAreaRareData& ensureRareData() 484 PaintLayerScrollableAreaRareData& ensureRareData()
486 { 485 {
487 if (!m_rareData) 486 if (!m_rareData)
488 m_rareData = wrapUnique(new PaintLayerScrollableAreaRareData()); 487 m_rareData = wrapUnique(new PaintLayerScrollableAreaRareData());
489 return *m_rareData.get(); 488 return *m_rareData.get();
490 } 489 }
491 490
492 // PaintInvalidationCapableScrollableArea
493 LayoutBox& boxForScrollControlPaintInvalidation() const { return box(); }
494
495 PaintLayer& m_layer; 491 PaintLayer& m_layer;
496 492
497 PaintLayer* m_nextTopmostScrollChild; 493 PaintLayer* m_nextTopmostScrollChild;
498 PaintLayer* m_topmostScrollChild; 494 PaintLayer* m_topmostScrollChild;
499 495
500 // Keeps track of whether the layer is currently resizing, so events can cau se resizing to start and stop. 496 // Keeps track of whether the layer is currently resizing, so events can cau se resizing to start and stop.
501 unsigned m_inResizeMode : 1; 497 unsigned m_inResizeMode : 1;
502 unsigned m_scrollsOverflow : 1; 498 unsigned m_scrollsOverflow : 1;
503 499
504 unsigned m_inOverflowRelayout : 1; 500 unsigned m_inOverflowRelayout : 1;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 #endif 543 #endif
548 }; 544 };
549 545
550 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, ScrollableArea, scrollableArea, 546 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, ScrollableArea, scrollableArea,
551 scrollableArea->isPaintLayerScrollableArea(), 547 scrollableArea->isPaintLayerScrollableArea(),
552 scrollableArea.isPaintLayerScrollableArea()); 548 scrollableArea.isPaintLayerScrollableArea());
553 549
554 } // namespace blink 550 } // namespace blink
555 551
556 #endif // LayerScrollableArea_h 552 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698