Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2134793002: Remove the command buffer method glGetImageivCHROMIUM. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, krit, danakj+watch_chromium.org, Rik, f(malita), piman+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the command buffer method glGetImageivCHROMIUM. It is no longer necessary, since the browser compositor no longer needs access to the underlying GpuMemoryBuffers. This CL is a revert of "Expose GpuMemoryBufferId through glGetImageivCHROMIUM." > WebKit widgets that provide textures to TextureLayer need to also provide the > GpuMemoryBufferId if the texture is backed by a GpuMemoryBuffer. This CL > modifies the CHROMIUM Image extension to allow the GpuMemoryBuffer id to be > obtained by a new function glGetImageivCHROMIUM. BUG=608026 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7cb1503e57864170612b6a7ad6dc1b8c52907c44 Cr-Commit-Position: refs/heads/master@{#404502}

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : Merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -254 lines) Patch
M cc/test/test_gles2_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_gles2_interface.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt View 3 chunks +0 lines, -11 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 5 chunks +1 line, -19 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/context.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 2 chunks +0 lines, -15 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/ui/gles2/command_buffer_local.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/gles2/command_buffer_local.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M services/ui/public/cpp/lib/command_buffer_client_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/lib/command_buffer_client_impl.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes3D.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 4 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
erikchen
piman: Please review everything but third_party/WebKit/Source/platform/graphics kbr: Please review third_party/WebKit/Source/platform/graphics
4 years, 5 months ago (2016-07-08 19:44:52 UTC) #15
erikchen
kbr: Please review third_party/WebKit/Source/platform/graphics
4 years, 5 months ago (2016-07-08 19:45:17 UTC) #17
erikchen
sky: Please review services/ui/
4 years, 5 months ago (2016-07-08 19:45:46 UTC) #19
piman
lgtm
4 years, 5 months ago (2016-07-08 20:11:43 UTC) #20
sky
LGTM
4 years, 5 months ago (2016-07-08 20:49:28 UTC) #21
Ken Russell (switch to Gerrit)
Great! Thanks for following up and cleaning this up. LGTM
4 years, 5 months ago (2016-07-08 21:43:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134793002/40001
4 years, 5 months ago (2016-07-08 21:45:36 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 21:53:27 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:55:58 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cb1503e57864170612b6a7ad6dc1b8c52907c44
Cr-Commit-Position: refs/heads/master@{#404502}

Powered by Google App Engine
This is Rietveld 408576698