Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.cc

Issue 2134793002: Remove the command buffer method glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge conflict. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/in_process_command_buffer.h ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/in_process_command_buffer.cc
diff --git a/gpu/command_buffer/service/in_process_command_buffer.cc b/gpu/command_buffer/service/in_process_command_buffer.cc
index edc7f4f237dcb261912bf2f3396f5e7b2cb8336d..ad0a55581cf7c5dc1f9885ac6c9a2698073eb073 100644
--- a/gpu/command_buffer/service/in_process_command_buffer.cc
+++ b/gpu/command_buffer/service/in_process_command_buffer.cc
@@ -684,9 +684,6 @@ int32_t InProcessCommandBuffer::CreateImage(ClientBuffer buffer,
DCHECK(gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat(
internalformat, gpu_memory_buffer->GetFormat()));
- DCHECK(image_gmb_ids_map_.find(new_id) == image_gmb_ids_map_.end());
- image_gmb_ids_map_[new_id] = gpu_memory_buffer->GetId().id;
-
// This handle is owned by the GPU thread and must be passed to it or it
// will leak. In otherwords, do not early out on error between here and the
// queuing of the CreateImage task below.
@@ -791,10 +788,6 @@ void InProcessCommandBuffer::CreateImageOnGpuThread(
void InProcessCommandBuffer::DestroyImage(int32_t id) {
CheckSequencedThread();
- auto it = image_gmb_ids_map_.find(id);
- if (it != image_gmb_ids_map_.end())
- image_gmb_ids_map_.erase(it);
-
QueueTask(base::Bind(&InProcessCommandBuffer::DestroyImageOnGpuThread,
base::Unretained(this),
id));
@@ -833,14 +826,6 @@ int32_t InProcessCommandBuffer::CreateGpuMemoryBufferImage(
return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);
}
-int32_t InProcessCommandBuffer::GetImageGpuMemoryBufferId(unsigned image_id) {
- CheckSequencedThread();
- auto it = image_gmb_ids_map_.find(image_id);
- if (it != image_gmb_ids_map_.end())
- return it->second;
- return -1;
-}
-
void InProcessCommandBuffer::FenceSyncReleaseOnGpuThread(uint64_t release) {
DCHECK(!sync_point_client_->client_state()->IsFenceSyncReleased(release));
gles2::MailboxManager* mailbox_manager =
« no previous file with comments | « gpu/command_buffer/service/in_process_command_buffer.h ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698