services/ui/public/cpp/lib/command_buffer_client_impl.cc - Issue 2134793002: Remove the command buffer method glGetImageivCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/lib/command_buffer_client_impl.cc

Issue 2134793002: Remove the command buffer method glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge conflict. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/ui/public/cpp/lib/command_buffer_client_impl.h ('k') | third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/ui/public/cpp/lib/command_buffer_client_impl.cc

diff --git a/services/ui/public/cpp/lib/command_buffer_client_impl.cc b/services/ui/public/cpp/lib/command_buffer_client_impl.cc

index c4566d5f93515875033b8903e0dfede19d998ae1..3ca099391a1729126ac17b22af753320c5acf533 100644

--- a/services/ui/public/cpp/lib/command_buffer_client_impl.cc

+++ b/services/ui/public/cpp/lib/command_buffer_client_impl.cc

@@ -255,14 +255,6 @@ int32_t CommandBufferClientImpl::CreateGpuMemoryBufferImage(

return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);

}

-int32_t CommandBufferClientImpl::GetImageGpuMemoryBufferId(unsigned image_id) {

- // TODO(erikchen): Once this class supports IOSurface GpuMemoryBuffer backed

- // images, it will also need to keep a local cache from image id to

- // GpuMemoryBuffer id.

- NOTIMPLEMENTED();

- return -1;

void CommandBufferClientImpl::SignalQuery(uint32_t query,

const base::Closure& callback) {

// TODO(piman)