Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change that caused it to be reverted was that it made
preferences leak between tests when the Shell window was reused. This version
fixes that by storing a clean copy of the test-ready WebPrecerences created with
a brand new RenderView and using that to reset existing windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
Committed: https://crrev.com/d4c23ca618abaeeeba8b7f707bb2b1cb4460d642
Cr-Commit-Position: refs/heads/master@{#404627}

[carlosk, 2016-07-08 13:02:02]

Description was changed from

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
==========

to

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change created was that it caused preferences to leak
between tests reusing the Shell window. This version fixes that by storing a
clean copy of the test-ready WebPrecerences and using that to reset existing
windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
==========

[carlosk, 2016-07-08 13:03:16]

carlosk@chromium.org changed reviewers:
+ dpranke@chromium.org, mkwst@chromium.org

[carlosk, 2016-07-08 13:03:17]

mkwst@, dpranke@ PTAL.

More details on the investigation leading to this fix can be found in
crbug.com/576270.

[Mike West, 2016-07-08 13:16:37]

https://codereview.chromium.org/2134723002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (left):

https://codereview.chromium.org/2134723002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:313:
OverrideWebkitPrefs(&prefs);
I think you still need to call this against `default_prefs_`.

[Dirk Pranke, 2016-07-08 19:43:08]

I defer to mkwst@ here. lgtm if he's happy.

[carlosk, 2016-07-11 08:21:00]

Thanks.

https://codereview.chromium.org/2134723002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (left):

https://codereview.chromium.org/2134723002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:313:
OverrideWebkitPrefs(&prefs);
On 2016/07/08 13:16:37, Mike West wrote:
> I think you still need to call this against `default_prefs_`.

The default we save up there @ 295 does already include those so we don't have
to do that here again.

When the new RenderView is created with a call to
RenderViewHostImpl::CreateRenderView, it initializes its preferences  by calling
GetWebkitPreferences() which ends up calling
BlinkTestController::OverrideWebkitPrefs through the test specific
implementation of LayoutTestContentBrowserClient::OverrideWebkitPrefs.

[carlosk, 2016-07-11 08:24:02]

Description was changed from

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change created was that it caused preferences to leak
between tests reusing the Shell window. This version fixes that by storing a
clean copy of the test-ready WebPrecerences and using that to reset existing
windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
==========

to

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change that caused it to be reverted was that it made
preferences leak between tests when the Shell window was reused. This version
fixes that by storing a clean copy of the test-ready WebPrecerences created with
a brand new RenderView and using that to reset existing windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
==========

[Mike West, 2016-07-11 09:23:04]

Thanks, the bots are happy too, so LGTM.

[carlosk, 2016-07-11 09:24:27]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 10:34:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 10:36:18]

Description was changed from

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change that caused it to be reverted was that it made
preferences leak between tests when the Shell window was reused. This version
fixes that by storing a clean copy of the test-ready WebPrecerences created with
a brand new RenderView and using that to reset existing windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126
==========

to

==========
Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change that caused it to be reverted was that it made
preferences leak between tests when the Shell window was reused. This version
fixes that by storing a clean copy of the test-ready WebPrecerences created with
a brand new RenderView and using that to reset existing windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126

Committed: https://crrev.com/d4c23ca618abaeeeba8b7f707bb2b1cb4460d642
Cr-Commit-Position: refs/heads/master@{#404627}
==========

[commit-bot: I haz the power, 2016-07-11 10:36:20]

Patchset 2 (id:??) landed as
https://crrev.com/d4c23ca618abaeeeba8b7f707bb2b1cb4460d642
Cr-Commit-Position: refs/heads/master@{#404627}