components/test_runner/test_runner.cc - Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.cc

Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanly reset WebPreferences with the initial untampered defaults. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/test_preferences.cc ('k') | content/shell/browser/layout_test/blink_test_controller.h » ('j') | content/shell/browser/layout_test/blink_test_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_runner.cc

diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc

index 2c09561a1839db360232c7d819289024938affd2..0639f8d67adfb83940a2afb48dcc9c848a029412 100644

--- a/components/test_runner/test_runner.cc

+++ b/components/test_runner/test_runner.cc

@@ -2321,6 +2321,8 @@ void TestRunner::OverridePreference(const std::string& key,

prefs->should_respect_image_orientation = value->BooleanValue();

} else if (key == "WebKitWebSecurityEnabled") {

prefs->web_security_enabled = value->BooleanValue();

+ } else if (key == "WebKitSpatialNavigationEnabled") {

+ prefs->spatial_navigation_enabled = value->BooleanValue();

} else {

std::string message("Invalid name for preference: ");

message.append(key);