content/shell/browser/layout_test/blink_test_controller.h - Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanly reset WebPreferences with the initial untampered defaults. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/test_runner.cc ('k') | content/shell/browser/layout_test/blink_test_controller.cc » ('j') | content/shell/browser/layout_test/blink_test_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/blink_test_controller.h

diff --git a/content/shell/browser/layout_test/blink_test_controller.h b/content/shell/browser/layout_test/blink_test_controller.h

index be57e3841841e13e3c33ec531fcb58f9c5ce53d5..8a17fee3cfa3642195e533daea516b7e0eea12c2 100644

--- a/content/shell/browser/layout_test/blink_test_controller.h

+++ b/content/shell/browser/layout_test/blink_test_controller.h

@@ -248,6 +248,10 @@ class BlinkTestController : public base::NonThreadSafe,

gfx::Size initial_size_;

GURL test_url_;

+ // Stores the default test-adapted WebPreferences which is then used to fully

+ // reset the main window's preferences if and when it is reused.

+ WebPreferences default_prefs_;

// True if the WebPreferences of newly created RenderViewHost should be

// overridden with prefs_.

bool should_override_prefs_;