content/shell/renderer/layout_test/blink_test_helpers.h - Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_helpers.h

Issue 2134723002: Reland #1: Fix re-usage of stale cached WebPreferences in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanly reset WebPreferences with the initial untampered defaults. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/layout_test/blink_test_controller.cc ('K') | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/renderer/layout_test/blink_test_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/blink_test_helpers.h

diff --git a/content/shell/renderer/layout_test/blink_test_helpers.h b/content/shell/renderer/layout_test/blink_test_helpers.h

index ed71efcbf1d37d656f6bce3e2aa773eca73ff729..7538e561702809f682d3191caf63ad8a1646c2ab 100644

--- a/content/shell/renderer/layout_test/blink_test_helpers.h

+++ b/content/shell/renderer/layout_test/blink_test_helpers.h

@@ -16,9 +16,9 @@ struct TestPreferences;

namespace content {

struct WebPreferences;

-// The TestRunner library keeps its settings in a WebPreferenes object.

+// The TestRunner library keeps its settings in a TestPreferences object.

// The content_shell, however, uses WebPreferences. This method exports the

-// settings from the WebTestRunner library which are relevant for layout tests.

+// settings from the TestRunner library which are relevant for layout tests.

void ExportLayoutTestSpecificPreferences(

const test_runner::TestPreferences& from,

WebPreferences* to);