Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2134063002: Remove DOMWindowLifecycleObserver (Closed)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, haraken, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DOMWindowLifecycleObserver DOMWindowLifecycleObserver is used just to notify the observers of addition/removal of event listeners. The observers are not interested in observing lifecycle of DOMWindow at all. Hence, this CL removes DOMWindowLifecycleObserver by replacing it with simple inheritance of LocalDOMWindow::EventListenerObserver. BUG=610176 Committed: https://crrev.com/e8378a670b3b2242538161e6a7394a69e0edc969 Cr-Commit-Position: refs/heads/master@{#404644}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -184 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/frame/DOMWindowLifecycleNotifier.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/Source/core/frame/DOMWindowLifecycleNotifier.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/core/frame/DOMWindowLifecycleObserver.h View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 7 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-11 07:22:23 UTC) #2
dcheng
LGTM
4 years, 5 months ago (2016-07-11 07:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134063002/1
4 years, 5 months ago (2016-07-11 07:57:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/218553)
4 years, 5 months ago (2016-07-11 09:13:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134063002/20001
4 years, 5 months ago (2016-07-11 09:20:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252910)
4 years, 5 months ago (2016-07-11 11:45:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134063002/20001
4 years, 5 months ago (2016-07-11 11:51:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 13:05:42 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 13:08:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8378a670b3b2242538161e6a7394a69e0edc969
Cr-Commit-Position: refs/heads/master@{#404644}

Powered by Google App Engine
This is Rietveld 408576698