third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp - Issue 2134063002: Remove DOMWindowLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp

Issue 2134063002: Remove DOMWindowLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp

diff --git a/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp b/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp

index cc50258b41815fd13a98fd5038d342124019d990..d44eab531d10cfaa686e46d3a81cb71288d24b80 100644

--- a/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp

+++ b/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp

@@ -6,17 +6,16 @@

#include "core/dom/Document.h"

#include "core/events/Event.h"

-#include "core/frame/LocalDOMWindow.h"

#include "core/page/Page.h"

namespace blink {

DeviceSingleWindowEventController::DeviceSingleWindowEventController(Document& document)

: PlatformEventController(document.page())

- , DOMWindowLifecycleObserver(document.domWindow())

, m_needsCheckingNullEvents(true)

, m_document(document)

{

+ document.domWindow()->registerEventListenerObserver(this);

}

DeviceSingleWindowEventController::~DeviceSingleWindowEventController()

@@ -73,7 +72,6 @@ DEFINE_TRACE(DeviceSingleWindowEventController)

{

visitor->trace(m_document);

PlatformEventController::trace(visitor);

- DOMWindowLifecycleObserver::trace(visitor);

}

} // namespace blink