Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

Issue 2134063002: Remove DOMWindowLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, Google Inc. All rights reserved. 2 * Copyright (C) 2011, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are met: 5 * modification, are permitted provided that the following conditions are met:
6 * 6 *
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
14 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
16 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE 16 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
17 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 17 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
18 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 18 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
19 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 19 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
20 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 20 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
21 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 21 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
22 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH 22 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
23 * DAMAGE. 23 * DAMAGE.
24 */ 24 */
25 25
26 #include "modules/gamepad/NavigatorGamepad.h" 26 #include "modules/gamepad/NavigatorGamepad.h"
27 27
28 #include "core/dom/Document.h" 28 #include "core/dom/Document.h"
29 #include "core/frame/LocalDOMWindow.h"
30 #include "core/frame/LocalFrame.h" 29 #include "core/frame/LocalFrame.h"
31 #include "core/frame/Navigator.h" 30 #include "core/frame/Navigator.h"
32 #include "core/page/Page.h" 31 #include "core/page/Page.h"
33 #include "modules/gamepad/GamepadDispatcher.h" 32 #include "modules/gamepad/GamepadDispatcher.h"
34 #include "modules/gamepad/GamepadEvent.h" 33 #include "modules/gamepad/GamepadEvent.h"
35 #include "modules/gamepad/GamepadList.h" 34 #include "modules/gamepad/GamepadList.h"
36 35
37 namespace blink { 36 namespace blink {
38 37
39 template<typename T> 38 template<typename T>
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 } 101 }
103 102
104 DEFINE_TRACE(NavigatorGamepad) 103 DEFINE_TRACE(NavigatorGamepad)
105 { 104 {
106 visitor->trace(m_gamepads); 105 visitor->trace(m_gamepads);
107 visitor->trace(m_pendingEvents); 106 visitor->trace(m_pendingEvents);
108 visitor->trace(m_dispatchOneEventRunner); 107 visitor->trace(m_dispatchOneEventRunner);
109 Supplement<Navigator>::trace(visitor); 108 Supplement<Navigator>::trace(visitor);
110 DOMWindowProperty::trace(visitor); 109 DOMWindowProperty::trace(visitor);
111 PlatformEventController::trace(visitor); 110 PlatformEventController::trace(visitor);
112 DOMWindowLifecycleObserver::trace(visitor);
113 } 111 }
114 112
115 bool NavigatorGamepad::startUpdatingIfAttached() 113 bool NavigatorGamepad::startUpdatingIfAttached()
116 { 114 {
117 // The frame must be attached to start updating. 115 // The frame must be attached to start updating.
118 if (frame() && frame()->host()) { 116 if (frame() && frame()->host()) {
119 startUpdating(); 117 startUpdating();
120 return true; 118 return true;
121 } 119 }
122 return false; 120 return false;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 const AtomicString& eventName = gamepad->connected() ? EventTypeNames::gamep adconnected : EventTypeNames::gamepaddisconnected; 159 const AtomicString& eventName = gamepad->connected() ? EventTypeNames::gamep adconnected : EventTypeNames::gamepaddisconnected;
162 frame()->domWindow()->dispatchEvent(GamepadEvent::create(eventName, false, t rue, gamepad)); 160 frame()->domWindow()->dispatchEvent(GamepadEvent::create(eventName, false, t rue, gamepad));
163 161
164 if (!m_pendingEvents.isEmpty()) 162 if (!m_pendingEvents.isEmpty())
165 m_dispatchOneEventRunner->runAsync(); 163 m_dispatchOneEventRunner->runAsync();
166 } 164 }
167 165
168 NavigatorGamepad::NavigatorGamepad(LocalFrame* frame) 166 NavigatorGamepad::NavigatorGamepad(LocalFrame* frame)
169 : DOMWindowProperty(frame) 167 : DOMWindowProperty(frame)
170 , PlatformEventController(frame ? frame->page() : 0) 168 , PlatformEventController(frame ? frame->page() : 0)
171 , DOMWindowLifecycleObserver(frame ? frame->localDOMWindow() : 0)
172 , m_dispatchOneEventRunner(AsyncMethodRunner<NavigatorGamepad>::create(this, &NavigatorGamepad::dispatchOneEvent)) 169 , m_dispatchOneEventRunner(AsyncMethodRunner<NavigatorGamepad>::create(this, &NavigatorGamepad::dispatchOneEvent))
173 { 170 {
171 if (frame)
172 frame->localDOMWindow()->registerEventListenerObserver(this);
174 } 173 }
175 174
176 NavigatorGamepad::~NavigatorGamepad() 175 NavigatorGamepad::~NavigatorGamepad()
177 { 176 {
178 } 177 }
179 178
180 const char* NavigatorGamepad::supplementName() 179 const char* NavigatorGamepad::supplementName()
181 { 180 {
182 return "NavigatorGamepad"; 181 return "NavigatorGamepad";
183 } 182 }
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 if (connectedGamepadChanged || (!oldWasConnected && newIsConnected)) { 278 if (connectedGamepadChanged || (!oldWasConnected && newIsConnected)) {
280 m_pendingEvents.append(newGamepad); 279 m_pendingEvents.append(newGamepad);
281 } 280 }
282 } 281 }
283 282
284 if (!m_pendingEvents.isEmpty()) 283 if (!m_pendingEvents.isEmpty())
285 m_dispatchOneEventRunner->runAsync(); 284 m_dispatchOneEventRunner->runAsync();
286 } 285 }
287 286
288 } // namespace blink 287 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698