third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h - Issue 2134063002: Remove DOMWindowLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h

Issue 2134063002: Remove DOMWindowLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindowLifecycleObserver.h ('k') | third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h

diff --git a/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h b/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h

index 4ceece75dc053164451ebe6f8658066fb0f2cd1e..2f8a395e5a022f376b3463e2fdcee76057aca311 100644

--- a/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h

+++ b/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.h

@@ -6,7 +6,7 @@

#define DeviceSingleWindowEventController_h

#include "core/CoreExport.h"

-#include "core/frame/DOMWindowLifecycleObserver.h"

+#include "core/frame/LocalDOMWindow.h"

#include "core/frame/PlatformEventController.h"

#include "platform/heap/Handle.h"

@@ -15,7 +15,7 @@ namespace blink {

class Document;

class Event;

-class CORE_EXPORT DeviceSingleWindowEventController : public GarbageCollectedFinalized<DeviceSingleWindowEventController>, public PlatformEventController, public DOMWindowLifecycleObserver {

+class CORE_EXPORT DeviceSingleWindowEventController : public GarbageCollectedFinalized<DeviceSingleWindowEventController>, public PlatformEventController, public LocalDOMWindow::EventListenerObserver {

public:

virtual ~DeviceSingleWindowEventController();

@@ -23,7 +23,7 @@ public:

void didUpdateData() override;

DECLARE_VIRTUAL_TRACE();

- // Inherited from DOMWindowLifecycleObserver.

+ // Inherited from LocalDOMWindow::EventListenerObserver.

void didAddEventListener(LocalDOMWindow*, const AtomicString&) override;

void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) override;

void didRemoveAllEventListeners(LocalDOMWindow*) override;