GN: Move towards only using / on Windows

GN: Move towards only using / on Windows

Remove most of the \ handling code, and start some normalization to /
as necessary. Paths that come from actions, etc. aren't validated yet.

This makes the Windows build get farther, but now it fails
with things similar to:

ninja: Entering directory `out_gn2'
ninja: error: WriteFile(obj/third_party/re2/re2/re2.unicode_groups.obj.rsp): Unable to create file. No such file or directory

Looks like we're not creating the subtree for ninja to write
rsp files to? Not sure.

This removes the last argument from rebase_path, so might have some
migration issues in landing the binary.

R=brettw@chromium.org
BUG=354626
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261311

[scottmg, 2014-04-02 00:23:38]

https://codereview.chromium.org/213353004/diff/1/base/files/file_path.h
File base/files/file_path.h (right):

https://codereview.chromium.org/213353004/diff/1/base/files/file_path.h#newco...
base/files/file_path.h:379: FilePath NormalizePathSeparatorsTo(CharType
separator) const;
Another alternative could be to create AppendWithSeparator and use that instead
of normalizing afterwards. This wouldn't silently fix the user passing in
c:\source, which might be better or worse.

[brettw, 2014-04-02 17:34:28]

I think I would like to keep the "convert slashes" flag on PathOutput since
we'll want this for the VC exporter.

https://codereview.chromium.org/213353004/diff/20001/base/files/file_path.cc
File base/files/file_path.cc (right):

https://codereview.chromium.org/213353004/diff/20001/base/files/file_path.cc#...
base/files/file_path.cc:1299: #if defined(FILE_PATH_USES_WIN_SEPARATORS)
How about DCHECKing here that separator == kSeparators[0] or kSeparators[1]?

https://codereview.chromium.org/213353004/diff/20001/tools/gn/build_settings.cc
File tools/gn/build_settings.cc (right):

https://codereview.chromium.org/213353004/diff/20001/tools/gn/build_settings....
tools/gn/build_settings.cc:29: root_path_ = r.NormalizePathSeparatorsTo(L'/');
I don't normally use L for ASCII characters. Bare '' is fine.

[scottmg, 2014-04-02 20:20:18]

Restored convert_slashes in PathOutput.

https://codereview.chromium.org/213353004/diff/20001/base/files/file_path.cc
File base/files/file_path.cc (right):

https://codereview.chromium.org/213353004/diff/20001/base/files/file_path.cc#...
base/files/file_path.cc:1299: #if defined(FILE_PATH_USES_WIN_SEPARATORS)
On 2014/04/02 17:34:28, brettw wrote:
> How about DCHECKing here that separator == kSeparators[0] or kSeparators[1]?

Done.

https://codereview.chromium.org/213353004/diff/20001/tools/gn/build_settings.cc
File tools/gn/build_settings.cc (right):

https://codereview.chromium.org/213353004/diff/20001/tools/gn/build_settings....
tools/gn/build_settings.cc:29: root_path_ = r.NormalizePathSeparatorsTo(L'/');
On 2014/04/02 17:34:28, brettw wrote:
> I don't normally use L for ASCII characters. Bare '' is fine.

Done.

[brettw, 2014-04-02 20:24:58]

lgtm

[scottmg, 2014-04-02 20:30:38]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-04-02 20:32:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/213353004/60001

[commit-bot: I haz the power, 2014-04-03 07:45:47]

Change committed as 261311