Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/gn/source_dir.cc

Issue 213353004: GN: Move towards only using / on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: restore convert_slashes in output path, misc fixes Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/source_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/source_dir.cc
diff --git a/tools/gn/source_dir.cc b/tools/gn/source_dir.cc
index 81340f94d2b4988af701bdfbae076310e4b571f8..c59cf88cd61136bc4e1fa6db7620b8c55e736736 100644
--- a/tools/gn/source_dir.cc
+++ b/tools/gn/source_dir.cc
@@ -130,14 +130,13 @@ base::FilePath SourceDir::Resolve(const base::FilePath& source_root) const {
} else {
converted.assign(value_);
}
- ConvertPathToSystem(&converted);
return base::FilePath(UTF8ToFilePath(converted));
}
// String the double-leading slash for source-relative paths.
converted.assign(&value_[2], value_.size() - 2);
- ConvertPathToSystem(&converted);
- return source_root.Append(UTF8ToFilePath(converted));
+ return source_root.Append(UTF8ToFilePath(converted))
+ .NormalizePathSeparatorsTo('/');
}
void SourceDir::SwapValue(std::string* v) {
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/source_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698