tools/gn/ninja_binary_target_writer.cc - Issue 213353004: GN: Move towards only using / on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 213353004: GN: Move towards only using / on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: restore convert_slashes in output path, misc fixes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index f0ef57c33286ab3dc4da9f5917f6a323f78708fe..ae29b4642daea181e02b1f2e67dc4e6ba7fa95f2 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -262,8 +262,8 @@ void NinjaBinaryTargetWriter::WriteLinkerFlags(

if (!all_lib_dirs.empty()) {

// Since we're passing these on the command line to the linker and not

// to Ninja, we need to do shell escaping.

- PathOutput lib_path_output(path_output_.current_dir(), ESCAPE_NINJA_SHELL,

- true);

+ PathOutput lib_path_output(

+ path_output_.current_dir(), ESCAPE_NINJA_SHELL, false);

for (size_t i = 0; i < all_lib_dirs.size(); i++) {

out_ << " " << tool.lib_dir_prefix;

lib_path_output.WriteDir(out_, all_lib_dirs[i],

« no previous file with comments | « tools/gn/function_rebase_path_unittest.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »