tools/gn/ninja_helper.cc - Issue 213353004: GN: Move towards only using / on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_helper.cc

Issue 213353004: GN: Move towards only using / on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: restore convert_slashes in output path, misc fixes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_helper.cc

diff --git a/tools/gn/ninja_helper.cc b/tools/gn/ninja_helper.cc

index 849ec4d9f5f7aa75898ab0647917bb0009483136..f84d2b1dc7c61848563cd5ea68134b217c3176a9 100644

--- a/tools/gn/ninja_helper.cc

+++ b/tools/gn/ninja_helper.cc

@@ -25,7 +25,6 @@ NinjaHelper::NinjaHelper(const BuildSettings* build_settings)

build_to_src_no_last_slash_.resize(build_to_src_no_last_slash_.size() - 1);

build_to_src_system_no_last_slash_ = build_to_src_no_last_slash_;

- ConvertPathToSystem(&build_to_src_system_no_last_slash_);

}

NinjaHelper::~NinjaHelper() {

« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »