Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2131653002: Cleanup ownership of parser members (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@parser_split
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup ownership of parser members Change m_pXMLDoc and m_pStream in CXFA_SimpleParser to be a unique_ptr. This allows removing the CloseParser() call from CXFA_DocumentParser as the items will get cleaned up automatically. Committed: https://pdfium.googlesource.com/pdfium/+/bb95c50663a1ba3378c6b079dc21dc7deb8ea53a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase to master #

Patch Set 3 : Review feedback #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -62 lines) Patch
M xfa/fde/xml/fde_xml_imp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.cpp View 1 2 chunks +3 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.h View 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 2 21 chunks +59 lines, -51 lines 0 comments Download

Depends on Patchset:

Issue 2129963002 Patch 100001

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-07 18:34:04 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/2131653002/diff/1/xfa/fxfa/parser/cxfa_simple_parser.cpp File xfa/fxfa/parser/cxfa_simple_parser.cpp (right): https://codereview.chromium.org/2131653002/diff/1/xfa/fxfa/parser/cxfa_simple_parser.cpp#newcode80 xfa/fxfa/parser/cxfa_simple_parser.cpp:80: } Blank line here? Ditto. https://codereview.chromium.org/2131653002/diff/1/xfa/fxfa/parser/cxfa_simple_parser.cpp#newcode109 xfa/fxfa/parser/cxfa_simple_parser.cpp:109: m_pStream.reset(pStream); ...
4 years, 5 months ago (2016-07-07 22:22:11 UTC) #3
dsinclair
https://codereview.chromium.org/2131653002/diff/1/xfa/fxfa/parser/cxfa_simple_parser.cpp File xfa/fxfa/parser/cxfa_simple_parser.cpp (right): https://codereview.chromium.org/2131653002/diff/1/xfa/fxfa/parser/cxfa_simple_parser.cpp#newcode80 xfa/fxfa/parser/cxfa_simple_parser.cpp:80: } On 2016/07/07 22:22:11, Wei Li wrote: > Blank ...
4 years, 5 months ago (2016-07-11 13:41:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131653002/60001
4 years, 5 months ago (2016-07-11 15:53:55 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:55:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/bb95c50663a1ba3378c6b079dc21dc7deb8e...

Powered by Google App Engine
This is Rietveld 408576698