xfa/fde/xml/fde_xml_imp.h - Issue 2131653002: Cleanup ownership of parser members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/xml/fde_xml_imp.h

Issue 2131653002: Cleanup ownership of parser members (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@parser_split

Patch Set: Rebase to master Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fde/xml/fde_xml_imp.h

diff --git a/xfa/fde/xml/fde_xml_imp.h b/xfa/fde/xml/fde_xml_imp.h

index ba75f6b4096a6fa9408047e415ace63a0d9f8bec..2667a106b7544802d2df23495e6b3d9e7c131876 100644

--- a/xfa/fde/xml/fde_xml_imp.h

+++ b/xfa/fde/xml/fde_xml_imp.h

@@ -193,7 +193,6 @@ class CFDE_XMLDoc : public CFX_Target {

CFDE_XMLDoc();

~CFDE_XMLDoc() override;

- void Release() { delete this; }

FX_BOOL LoadXML(CFDE_XMLParser* pXMLParser);

int32_t DoLoad(IFX_Pause* pPause = nullptr);

void CloseXML();

« no previous file with comments | « no previous file | xfa/fxfa/parser/cxfa_document_parser.h » ('j') | no next file with comments »