xfa/fxfa/parser/cxfa_document_parser.h - Issue 2131653002: Cleanup ownership of parser members

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxfa/parser/cxfa_document_parser.h

Issue 2131653002: Cleanup ownership of parser members (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@parser_split

Patch Set: Rebase to master Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « xfa/fde/xml/fde_xml_imp.h ('k') | xfa/fxfa/parser/cxfa_document_parser.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 PDFium Authors. All rights reserved.	1 // Copyright 2016 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_	7 #ifndef XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_

8 #define XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_	8 #define XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_

9	9

10 #include <memory>	10 #include <memory>

(...skipping 11 matching lines...) Expand all Loading...
22 public:	22 public:

23 explicit CXFA_DocumentParser(CXFA_FFNotify* pNotify);	23 explicit CXFA_DocumentParser(CXFA_FFNotify* pNotify);

24 ~CXFA_DocumentParser();	24 ~CXFA_DocumentParser();

25	25

26 int32_t StartParse(IFX_FileRead* pStream, XFA_XDPPACKET ePacketID);	26 int32_t StartParse(IFX_FileRead* pStream, XFA_XDPPACKET ePacketID);

27 int32_t DoParse(IFX_Pause* pPause);	27 int32_t DoParse(IFX_Pause* pPause);

28	28

29 CFDE_XMLDoc* GetXMLDoc() const;	29 CFDE_XMLDoc* GetXMLDoc() const;

30 CXFA_FFNotify* GetNotify() const;	30 CXFA_FFNotify* GetNotify() const;

31 CXFA_Document* GetDocument() const;	31 CXFA_Document* GetDocument() const;

32 void CloseParser();

33	32

34 protected:	33 protected:

35 CXFA_SimpleParser m_nodeParser;	34 CXFA_SimpleParser m_nodeParser;

36 CXFA_FFNotify* m_pNotify;	35 CXFA_FFNotify* m_pNotify;

37 std::unique_ptr<CXFA_Document> m_pDocument;	36 std::unique_ptr<CXFA_Document> m_pDocument;

38 };	37 };

39	38

40 #endif // XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_	39 #endif // XFA_FXFA_PARSER_CXFA_DOCUMENT_PARSER_H_

OLD	NEW