Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129963002: Break xfa_parser_imp apart (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@ixfa_parser
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Break xfa_parser_imp apart This CL splits the three parsers into individual files to make working with the code easier. Committed: https://pdfium.googlesource.com/pdfium/+/34f86b0c7816289d2a0b402d1909572f4e95613b

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Missing fuzzer headers #

Total comments: 10

Patch Set 4 : Rebase to master #

Patch Set 5 : Review feedback #

Patch Set 6 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -1998 lines) Patch
M BUILD.gn View 1 2 3 5 chunks +7 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa.gyp View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffdoc.h View 1 chunk +1 line, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_document_parser.h View 1 chunk +40 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_document_parser.cpp View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_simple_parser.h View 2 chunks +7 lines, -53 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 2 chunks +4 lines, -228 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_simple_parser_embeddertest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A xfa/fxfa/parser/cxfa_xml_parser.h View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_xml_parser.cpp View 1 2 3 4 1 chunk +176 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxfa/parser/xfa_parser_imp.h View 1 chunk +0 lines, -132 lines 0 comments Download
D xfa/fxfa/parser/xfa_parser_imp.cpp View 1 1 chunk +0 lines, -1542 lines 0 comments Download
D xfa/fxfa/parser/xfa_parser_imp_embeddertest.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2123133004 Patch 100001

Dependent Patchsets:

Issue 2131653002 Patch 60001

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-07 15:13:55 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/2129963002/diff/40001/xfa/fxfa/parser/cxfa_document_parser.cpp File xfa/fxfa/parser/cxfa_document_parser.cpp (right): https://codereview.chromium.org/2129963002/diff/40001/xfa/fxfa/parser/cxfa_document_parser.cpp#newcode1 xfa/fxfa/parser/cxfa_document_parser.cpp:1: // Copyright 2014 PDFium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-07 21:34:14 UTC) #3
dsinclair
https://codereview.chromium.org/2129963002/diff/40001/xfa/fxfa/parser/cxfa_document_parser.cpp File xfa/fxfa/parser/cxfa_document_parser.cpp (right): https://codereview.chromium.org/2129963002/diff/40001/xfa/fxfa/parser/cxfa_document_parser.cpp#newcode1 xfa/fxfa/parser/cxfa_document_parser.cpp:1: // Copyright 2014 PDFium Authors. All rights reserved. On ...
4 years, 5 months ago (2016-07-11 13:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129963002/100001
4 years, 5 months ago (2016-07-11 15:27:09 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:42:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/34f86b0c7816289d2a0b402d1909572f4e95...

Powered by Google App Engine
This is Rietveld 408576698