Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2130153002: Clean up max_frame_size related constants, move storage of setting to the framer. (Closed)

Created:
4 years, 5 months ago by yinjie
Modified:
4 years, 5 months ago
Reviewers:
Bence, yinjie1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up max_frame_size related constants, move storage of setting to the framer. No functional change, not flag-protected. This CL lands server change 126437339 by dahollings. BUG=488484 Committed: https://crrev.com/164d046389e2ccf68bda622362427dc6c7bf94fb Cr-Commit-Position: refs/heads/master@{#404585}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix a typo in net/spdy/spdy_protocol.h. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_frame_builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/spdy_framer.h View 3 chunks +14 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 2 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130153002/1
4 years, 5 months ago (2016-07-08 00:37:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-08 01:54:13 UTC) #4
yinjie
4 years, 5 months ago (2016-07-08 16:27:25 UTC) #6
Bence
Please change CL title to fix on one line. (Second sentence can be the second ...
4 years, 5 months ago (2016-07-08 20:19:01 UTC) #7
yinjie
On 2016/07/08 20:19:01, Bence wrote: > Please change CL title to fix on one line. ...
4 years, 5 months ago (2016-07-08 22:41:44 UTC) #11
Bence
On 2016/07/08 22:41:44, yinjie wrote: > On 2016/07/08 20:19:01, Bence wrote: > > Please change ...
4 years, 5 months ago (2016-07-09 14:05:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130153002/20001
4 years, 5 months ago (2016-07-10 21:19:15 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 01:13:42 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 01:16:40 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/164d046389e2ccf68bda622362427dc6c7bf94fb
Cr-Commit-Position: refs/heads/master@{#404585}

Powered by Google App Engine
This is Rietveld 408576698