Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: net/spdy/spdy_framer.h

Issue 2130153002: Clean up max_frame_size related constants, move storage of setting to the framer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a typo in net/spdy/spdy_protocol.h. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer.h
diff --git a/net/spdy/spdy_framer.h b/net/spdy/spdy_framer.h
index 0809b662d8e271b28a84daab658482ef010f707c..b5293e7dd40cd3690aa64b9966df9b3beaa5a621 100644
--- a/net/spdy/spdy_framer.h
+++ b/net/spdy/spdy_framer.h
@@ -519,6 +519,12 @@ class NET_EXPORT_PRIVATE SpdyFramer {
max_decode_buffer_size_bytes);
}
+ size_t send_frame_size_limit() const { return send_frame_size_limit_; }
+
+ void set_send_frame_size_limit(size_t send_frame_size_limit) {
+ send_frame_size_limit_ = send_frame_size_limit;
+ }
+
void set_recv_frame_size_limit(size_t recv_frame_size_limit) {
recv_frame_size_limit_ = recv_frame_size_limit;
}
@@ -739,6 +745,8 @@ class NET_EXPORT_PRIVATE SpdyFramer {
// removed) if necessary later down the line.
// TODO(diannahu): Rename to make it clear that this limit is for sending.
static const size_t kMaxControlFrameSize;
+ // The maximum size for the payload of DATA frames to send.
+ static const size_t kMaxDataPayloadSendSize;
SpdyState state_;
SpdyState previous_state_;
@@ -757,8 +765,12 @@ class NET_EXPORT_PRIVATE SpdyFramer {
// are part of the frame's payload, and not the frame's headers.
size_t remaining_control_header_;
- // The limit on HTTP/2 payload size as specified in the
- // SETTINGS_MAX_FRAME_SIZE advertised to peer
+ // The limit on the size of sent HTTP/2 payloads as specified in the
+ // SETTINGS_MAX_FRAME_SIZE received from peer.
+ size_t send_frame_size_limit_ = kSpdyInitialFrameSizeLimit;
+
+ // The limit on the size of received HTTP/2 payloads as specified in the
+ // SETTINGS_MAX_FRAME_SIZE advertised to peer.
size_t recv_frame_size_limit_ = kSpdyInitialFrameSizeLimit;
CharBuffer current_frame_buffer_;
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698