Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: net/spdy/spdy_protocol.h

Issue 2130153002: Clean up max_frame_size related constants, move storage of setting to the framer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a typo in net/spdy/spdy_protocol.h. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | net/spdy/spdy_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.h
diff --git a/net/spdy/spdy_protocol.h b/net/spdy/spdy_protocol.h
index ff492e293e8a77e110363d7ac9fdda899debdf32..2b94246a5700aa709a4411c12ac3517e526242d7 100644
--- a/net/spdy/spdy_protocol.h
+++ b/net/spdy/spdy_protocol.h
@@ -50,7 +50,7 @@ typedef uint32_t SpdyStreamId;
// flow control).
const SpdyStreamId kSessionFlowControlStreamId = 0;
-// The maxmium possible frame payload size allowed by the spec.
+// The maximum possible frame payload size allowed by the spec.
const uint32_t kSpdyMaxFrameSizeLimit = (1 << 24) - 1;
// The initial value for the maximum frame payload size as per the spec. This is
@@ -532,12 +532,16 @@ class NET_EXPORT_PRIVATE SpdyConstants {
// for this value as opposed to a constant.
static size_t GetDataFrameMinimumSize(SpdyMajorVersion version);
+ // Number of octets in the frame header
+ static size_t GetFrameHeaderSize(SpdyMajorVersion version);
+
// Size, in bytes, of the control frame header.
static size_t GetControlFrameHeaderSize(SpdyMajorVersion version);
static size_t GetPrefixLength(SpdyFrameType type, SpdyMajorVersion version);
- static size_t GetFrameMaximumSize(SpdyMajorVersion version);
+ // Maximum possible configurable size of a frame in octets.
+ static size_t GetMaxFrameSizeLimit(SpdyMajorVersion version);
// Returns the size of a header block size field. Valid only for SPDY 3.
static size_t GetSizeOfSizeField();
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | net/spdy/spdy_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698