Clean up max_frame_size related constants, move storage of setting to the framer.

net/spdy/spdy_protocol.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains some protocol structures for use with SPDY 3 and HTTP 2
 // The SPDY 3 spec can be found at:
 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3
 
 #ifndef NET_SPDY_SPDY_PROTOCOL_H_
 #define NET_SPDY_SPDY_PROTOCOL_H_
@@ skipping 32 matching lines @@
 // 15 bit version field for SPDY/3 frames.
 const uint16_t kSpdy3Version = 3;
 
 // A SPDY stream id is a 31 bit entity.
 typedef uint32_t SpdyStreamId;
 
 // Specifies the stream ID used to denote the current session (for
 // flow control).
 const SpdyStreamId kSessionFlowControlStreamId = 0;
 
 // The maxmium possible frame payload size allowed by the spec.

[Bence, 2016/07/08 20:19:01]

Please fix this typo: this is part of change 126437339.

 const uint32_t kSpdyMaxFrameSizeLimit = (1 << 24) - 1;
 
 // The initial value for the maximum frame payload size as per the spec. This is
 // the maximum control frame size we accept.
 const uint32_t kSpdyInitialFrameSizeLimit = 1 << 14;
 
 // The initial value for the maximum size of the header list, "unlimited" (max
 // unsigned 32-bit int) as per the spec.
 const uint32_t kSpdyInitialHeaderListSizeLimit = 0xFFFFFFFF;
 
@@ skipping 461 matching lines @@
   // the given protocol version.
   // Returns -1 on failure (I.E. Invalid GOAWAY status for the given version).
   static int SerializeGoAwayStatus(SpdyMajorVersion version,
                                    SpdyGoAwayStatus status);
 
   // Size, in bytes, of the data frame header. Future versions of SPDY
   // will likely vary this, so we allow for the flexibility of a function call
   // for this value as opposed to a constant.
   static size_t GetDataFrameMinimumSize(SpdyMajorVersion version);
 
+  // Number of octets in the frame header
+  static size_t GetFrameHeaderSize(SpdyMajorVersion version);
+
   // Size, in bytes, of the control frame header.
   static size_t GetControlFrameHeaderSize(SpdyMajorVersion version);
 
   static size_t GetPrefixLength(SpdyFrameType type, SpdyMajorVersion version);
 
-  static size_t GetFrameMaximumSize(SpdyMajorVersion version);
+  // Maximum possible configurable size of a frame in octets.
+  static size_t GetMaxFrameSizeLimit(SpdyMajorVersion version);
 
   // Returns the size of a header block size field. Valid only for SPDY 3.
   static size_t GetSizeOfSizeField();
 
   // Returns the per-header overhead for block size accounting in bytes.
   static size_t GetPerHeaderOverhead(SpdyMajorVersion version);
 
   // Returns the size (in bytes) of a wire setting ID and value.
   static size_t GetSettingSize(SpdyMajorVersion version);
 
@@ skipping 679 matching lines @@
   SpdyFrameVisitor() {}
   virtual ~SpdyFrameVisitor() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_PROTOCOL_H_