Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2129863002: Handle focusability for plugin elements which has browsing context (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle focusability for plugin elements which has browsing context If <object> or <embed> has HTML/SVG contents, focus navigation within documents under these elements should work. This has been working fine for <iframe>s. The FocusController code checks for FrameOwnerElement, which is parent of <iframe>, <object>, and <embed> if it is isKeyboardFocusable() and has contentFrame(). HTMLPluginElement::isKeyboardFocsuable() didn't handle the cases with HTML/SVG contents, only considered plugins. BUG=620488 Committed: https://crrev.com/a2c82afad86cf4f85f91df76f858434b15fe6b13 Cr-Commit-Position: refs/heads/master@{#404324}

Patch Set 1 #

Patch Set 2 : layout test #

Patch Set 3 : use super class. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/focus-navigation-in-plugin.html View 1 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/resources/plugin-focus-subframe.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129863002/1
4 years, 5 months ago (2016-07-07 09:34:12 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 10:47:51 UTC) #4
kochi
Could you review this?
4 years, 5 months ago (2016-07-08 05:16:13 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129863002/40001
4 years, 5 months ago (2016-07-08 05:16:27 UTC) #9
tkent
lgtm
4 years, 5 months ago (2016-07-08 05:34:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129863002/40001
4 years, 5 months ago (2016-07-08 05:40:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 09:34:07 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:34:21 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:36:16 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2c82afad86cf4f85f91df76f858434b15fe6b13
Cr-Commit-Position: refs/heads/master@{#404324}

Powered by Google App Engine
This is Rietveld 408576698