third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h - Issue 2129863002: Handle focusability for plugin elements which has browsing context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2129863002: Handle focusability for plugin elements which has browsing context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use super class. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/resources/plugin-focus-subframe.html ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

index 1f9eed4a360a1ba6b1aeef1aec81f3c2b43c6745..975a9ffbff04d02cfbbdb9d160c952d388494e40 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

@@ -92,6 +92,7 @@ protected:

void setSandboxFlags(SandboxFlags);

bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem);

+ bool isKeyboardFocusable() const override;

private:

// Intentionally private to prevent redundant checks when the type is

@@ -99,7 +100,6 @@ private:

bool isLocal() const override { return true; }

bool isRemote() const override { return false; }

- bool isKeyboardFocusable() const override;

bool isFrameOwnerElement() const final { return true; }

virtual ReferrerPolicy referrerPolicyAttribute() { return ReferrerPolicyDefault; }