third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2129863002: Handle focusability for plugin elements which has browsing context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2129863002: Handle focusability for plugin elements which has browsing context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use super class. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index db0e19a69837406329c6badb754d0a8a627e0ee6..b62b61d259caa823d3906ddce8810531b4a1da8d 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -375,9 +375,9 @@ LayoutPart* HTMLPlugInElement::layoutPartForJSBindings() const

bool HTMLPlugInElement::isKeyboardFocusable() const

{

- if (!document().isActive())

- return false;

- return pluginWidget() && pluginWidget()->isPluginView() && toPluginView(pluginWidget())->supportsKeyboardFocus();

+ if (HTMLFrameOwnerElement::isKeyboardFocusable())

+ return true;

+ return document().isActive() && pluginWidget() && pluginWidget()->isPluginView() && toPluginView(pluginWidget())->supportsKeyboardFocus();

}

bool HTMLPlugInElement::hasCustomFocusLogic() const

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h ('k') | no next file » | no next file with comments »