Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2129863002: Handle focusability for plugin elements which has browsing context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use super class. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 { 368 {
369 // Needs to load the plugin immediatedly because this function is called 369 // Needs to load the plugin immediatedly because this function is called
370 // when JavaScript code accesses the plugin. 370 // when JavaScript code accesses the plugin.
371 // FIXME: Check if dispatching events here is safe. 371 // FIXME: Check if dispatching events here is safe.
372 document().updateStyleAndLayoutIgnorePendingStylesheets(Document::RunPostLay outTasksSynchronously); 372 document().updateStyleAndLayoutIgnorePendingStylesheets(Document::RunPostLay outTasksSynchronously);
373 return existingLayoutPart(); 373 return existingLayoutPart();
374 } 374 }
375 375
376 bool HTMLPlugInElement::isKeyboardFocusable() const 376 bool HTMLPlugInElement::isKeyboardFocusable() const
377 { 377 {
378 if (!document().isActive()) 378 if (HTMLFrameOwnerElement::isKeyboardFocusable())
379 return false; 379 return true;
380 return pluginWidget() && pluginWidget()->isPluginView() && toPluginView(plug inWidget())->supportsKeyboardFocus(); 380 return document().isActive() && pluginWidget() && pluginWidget()->isPluginVi ew() && toPluginView(pluginWidget())->supportsKeyboardFocus();
381 } 381 }
382 382
383 bool HTMLPlugInElement::hasCustomFocusLogic() const 383 bool HTMLPlugInElement::hasCustomFocusLogic() const
384 { 384 {
385 return !useFallbackContent(); 385 return !useFallbackContent();
386 } 386 }
387 387
388 bool HTMLPlugInElement::isPluginElement() const 388 bool HTMLPlugInElement::isPluginElement() const
389 { 389 {
390 return true; 390 return true;
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 603
604 void HTMLPlugInElement::lazyReattachIfNeeded() 604 void HTMLPlugInElement::lazyReattachIfNeeded()
605 { 605 {
606 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) { 606 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) {
607 lazyReattachIfAttached(); 607 lazyReattachIfAttached();
608 setPersistedPluginWidget(nullptr); 608 setPersistedPluginWidget(nullptr);
609 } 609 }
610 } 610 }
611 611
612 } // namespace blink 612 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698