Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 212953008: Revert of Distance field fixes for Android (Closed)

Created:
6 years, 9 months ago by jvanverth1
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Distance field fixes for Android (https://codereview.chromium.org/205343008/) Reason for revert: compile error at line 110 in GrDistanceFieldTextureEffect.cpp Original issue's description: > Distance field fixes for Android > - Expand glyph size by 2 on each side to compensate for bilerp lookup > - Correct for Adreno tendency to drop entire tile if any pixel has divide-by-0 > - Fix blurriness on Adreno by using uv coords to compute gradient instead > of st coords > - Add faster version for uniform scale > > BUG=skia:2173 > > Committed: http://code.google.com/p/skia/source/detail?r=13955 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=13956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -87 lines) Patch
M src/core/SkDistanceFieldGen.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 3 chunks +6 lines, -13 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 5 chunks +20 lines, -49 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of Distance field fixes for Android
6 years, 9 months ago (2014-03-26 18:20:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/212953008/1
6 years, 9 months ago (2014-03-26 18:21:01 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 18:22:12 UTC) #3
Message was sent while issue was closed.
Change committed as 13956

Powered by Google App Engine
This is Rietveld 408576698