Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2128403002: Remove constant ALL_BASELINE_VARIANTS from port/test.py. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove constant ALL_BASELINE_VARIANTS from port/test.py. Committed: https://crrev.com/20be8a5ab85d7ea41f1ed093869c80f4cae48bee Cr-Commit-Position: refs/heads/master@{#404690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
qyearsley
Hi Walter, can you confirm that this change makes sense? It seems that ALL_BASELINE_VARIANTS at ...
4 years, 5 months ago (2016-07-07 21:39:56 UTC) #3
wkorman
lgtm Sweet, sounds reasonable to me.
4 years, 5 months ago (2016-07-11 18:03:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128403002/1
4 years, 5 months ago (2016-07-11 18:06:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 18:12:00 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20be8a5ab85d7ea41f1ed093869c80f4cae48bee Cr-Commit-Position: refs/heads/master@{#404690}
4 years, 5 months ago (2016-07-11 18:15:33 UTC) #13
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:49:42 UTC) #15
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698