Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 2128403002: Remove constant ALL_BASELINE_VARIANTS from port/test.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
index 6697e3db55e5a717fdf7f2e0c7eccb513b851f86..9c88ae89c978bdaa35db4d470e8d5396a02fd783 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
@@ -365,19 +365,6 @@ class TestPort(Port):
port_name = 'test'
default_port_name = 'test-mac-mac10.10'
- # TODO(wkorman): The below constant is legacy code and is only referenced by a unit test. Find the modern way to do
- # the same thing that test is doing and delete this.
- #
- # A list of platform names sufficient to cover all the baselines.
- # The list should be sorted so that a later platform will reuse
- # an earlier platform's baselines if they are the same (e.g.,
- # 'mac10.10' should precede 'mac10.9').
- ALL_BASELINE_VARIANTS = (
- 'test-linux-trusty', 'test-linux-precise', 'test-linux-x86',
- 'test-mac-mac10.11', 'test-mac-mac10.10',
- 'test-win-win10', 'test-win-win7'
- )
-
FALLBACK_PATHS = {
'win7': ['test-win-win7', 'test-win-win10'],
'win10': ['test-win-win10'],
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698