Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 2128403002: Remove constant ALL_BASELINE_VARIANTS from port/test.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 filesystem.write_text_file(filesystem.join(LAYOUT_TEST_DIR, 'virtual', 'virt ual_passes', 358 filesystem.write_text_file(filesystem.join(LAYOUT_TEST_DIR, 'virtual', 'virt ual_passes',
359 'passes', 'args-expected.txt'), ' args-txt --virtual-arg') 359 'passes', 'args-expected.txt'), ' args-txt --virtual-arg')
360 # Clear the list of written files so that we can watch what happens during t esting. 360 # Clear the list of written files so that we can watch what happens during t esting.
361 filesystem.clear_written_files() 361 filesystem.clear_written_files()
362 362
363 363
364 class TestPort(Port): 364 class TestPort(Port):
365 port_name = 'test' 365 port_name = 'test'
366 default_port_name = 'test-mac-mac10.10' 366 default_port_name = 'test-mac-mac10.10'
367 367
368 # TODO(wkorman): The below constant is legacy code and is only referenced by a unit test. Find the modern way to do
369 # the same thing that test is doing and delete this.
370 #
371 # A list of platform names sufficient to cover all the baselines.
372 # The list should be sorted so that a later platform will reuse
373 # an earlier platform's baselines if they are the same (e.g.,
374 # 'mac10.10' should precede 'mac10.9').
375 ALL_BASELINE_VARIANTS = (
376 'test-linux-trusty', 'test-linux-precise', 'test-linux-x86',
377 'test-mac-mac10.11', 'test-mac-mac10.10',
378 'test-win-win10', 'test-win-win7'
379 )
380
381 FALLBACK_PATHS = { 368 FALLBACK_PATHS = {
382 'win7': ['test-win-win7', 'test-win-win10'], 369 'win7': ['test-win-win7', 'test-win-win10'],
383 'win10': ['test-win-win10'], 370 'win10': ['test-win-win10'],
384 'mac10.10': ['test-mac-mac10.10', 'test-mac-mac10.11'], 371 'mac10.10': ['test-mac-mac10.10', 'test-mac-mac10.11'],
385 'mac10.11': ['test-mac-mac10.11'], 372 'mac10.11': ['test-mac-mac10.11'],
386 'trusty': ['test-linux-trusty', 'test-win-win7'], 373 'trusty': ['test-linux-trusty', 'test-win-win7'],
387 'precise': ['test-linux-precise', 'test-linux-trusty', 'test-win-win7'], 374 'precise': ['test-linux-precise', 'test-linux-trusty', 'test-win-win7'],
388 'linux32': ['test-linux-x86', 'test-linux-precise', 'test-linux-trusty', 'test-win-win7'], 375 'linux32': ['test-linux-x86', 'test-linux-precise', 'test-linux-trusty', 'test-win-win7'],
389 } 376 }
390 377
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 else: 644 else:
658 image = test.actual_image 645 image = test.actual_image
659 return DriverOutput(actual_text, image, test.actual_checksum, audio, 646 return DriverOutput(actual_text, image, test.actual_checksum, audio,
660 crash=(crash or web_process_crash), crashed_process_ name=crashed_process_name, 647 crash=(crash or web_process_crash), crashed_process_ name=crashed_process_name,
661 crashed_pid=crashed_pid, crash_log=crash_log, 648 crashed_pid=crashed_pid, crash_log=crash_log,
662 test_time=time.time() - start_time, timeout=test.tim eout, error=test.error, pid=self.pid, 649 test_time=time.time() - start_time, timeout=test.tim eout, error=test.error, pid=self.pid,
663 leak=test.leak) 650 leak=test.leak)
664 651
665 def stop(self): 652 def stop(self):
666 self.started = False 653 self.started = False
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698